add batch_bytes configuration for Flint #329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peng Huo <[email protected]>
Signed-off-by: Peng Huo <[email protected]>
Signed-off-by: Peng Huo <[email protected]>
Signed-off-by: Peng Huo <[email protected]>
penghuo
requested review from
dai-chen,
rupal-bq,
vmmusings,
seankao-az,
anirudha,
kaituo and
YANG-DB
as code owners
dai-chen
reviewed
May 2, 2024
flint-core/src/main/scala/org/opensearch/flint/core/storage/FlintWriter.java
Show resolved
Hide resolved
flint-core/src/main/scala/org/opensearch/flint/core/storage/OpenSearchWriter.java
Outdated
Show resolved
Hide resolved
penghuo
changed the title
Signed-off-by: Peng Huo <[email protected]>
dai-chen
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Change the default value
spark.datasource.flint.write.batch_size: 1000 --> Integer.MAX_VALUE.spark.datasource.flint.write.refresh_policy: wait_for --> false.Add new settings
spark.datasource.flint.write.batch_bytes: The approximately amount of data in bytes written to Flint in a single batch request. The actual data write to OpenSearch may more than it. Default value is 1mb. The writing process checks after each document whether the total number of documents (docCount) has reached batch_size or the buffer size has surpassed batch_bytes. If either condition is met, the current batch is flushed and the document count resets to zero.Test Result
With EMR-S 3 Executors (4v CPU 16 GB memory), write to single node OpenSearch cluster, throughput is 40MB/s.
Issues Resolved
#304
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.